VWR-24337: Possible crash on llassert_always(purge_list.size() >= entries_to_purge)
Review Request #93 - Created Jan. 14, 2011 and submitted
| Aleric Inglewood | Reviewers | ||
| viewer | |||
| VWR-24337 | |||
| None | viewer-development | ||
Just fixed the logic, so entries_to_purge won't become negative anymore, and the rest.
Expand AllPosted (Jan. 20, 2011, 11:15 p.m.)
-
indra/newview/lltexturecache.cpp (Diff revision 1) -
I get it but it's a bit unsettling to have the condition seemingly unrelated to the iterator. I'd rather have a while () construction here so it's more clear what the intent is.
Review request changed
Updated (Jan. 21, 2011, 4:25 a.m.)
-
- added Diff r2
The new diff uses while(purge_list.size() < entries_to_purge), instead of a for() loop.
Other reviews