diff -r 422f636c3343 doc/contributions.txt --- a/doc/contributions.txt Fri Jan 14 10:28:29 2011 -0800 +++ b/doc/contributions.txt Fri Jan 21 13:24:05 2011 +0100 @@ -79,6 +79,7 @@ VWR-24252 VWR-24254 VWR-24261 + VWR-24337 SNOW-84 SNOW-477 SNOW-744 diff -r 422f636c3343 indra/newview/lltexturecache.cpp --- a/indra/newview/lltexturecache.cpp Fri Jan 14 10:28:29 2011 -0800 +++ b/indra/newview/lltexturecache.cpp Fri Jan 21 13:24:05 2011 +0100 @@ -1413,22 +1413,21 @@ } } } - if (num_entries > sCacheMaxEntries) + if (num_entries - empty_entries > sCacheMaxEntries) { // Special case: cache size was reduced, need to remove entries // Note: After we prune entries, we will call this again and create the LRU - U32 entries_to_purge = (num_entries-empty_entries) - sCacheMaxEntries; + U32 entries_to_purge = (num_entries - empty_entries) - sCacheMaxEntries; llinfos << "Texture Cache Entries: " << num_entries << " Max: " << sCacheMaxEntries << " Empty: " << empty_entries << " Purging: " << entries_to_purge << llendl; - if (entries_to_purge > 0) + // We can exit the following loop with the given condition, since if we'd reach the end of the lru set we'd have: + // purge_list.size() = lru.size() = num_entries - empty_entries = entries_to_purge + sCacheMaxEntries >= entries_to_purge + // So, it's certain that iter will never reach lru.end() first. + std::set::iterator iter = lru.begin(); + while (purge_list.size() < entries_to_purge) { - for (std::set::iterator iter = lru.begin(); iter != lru.end(); ++iter) - { - purge_list.insert(iter->second); - if (purge_list.size() >= entries_to_purge) - break; - } + purge_list.insert(iter->second); + ++iter; } - llassert_always(purge_list.size() >= entries_to_purge); } else {