All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

Fixed snapping of rotation in the edge-on case

Review Request #608 - Created Nov. 26, 2012 and updated

Cron Stardust Reviewers
viewer
STORM-1919
None viewer-release
Simply had to guard the snapping code, making sure that the last "else" case was preserved when either the outer or the inner tests failed.

Careful analysis and testing was performed to determine what clauses could/should be inside the guarding if statement, which led to the discovery that the else clause had to be preserved outside under a separate test.  Code structure was carefully designed to match the other llManip* classes in similar areas.
Tested all rotation cases (edge-on & facing multiplied with snapping enabled & disabled) in Firestorm - however this area of code has not been modified in either viewer since ancient times and should therefore cause no ill effects.
Ship it!
Posted (Nov. 26, 2012, 11:31 p.m.)
I have tested this patch against a beta of my dolphin viewer 3, and it works fine even with deeply modified build tools.
Ship it!
Posted (Nov. 27, 2012, 8:11 a.m.)
Ship It!