All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

Fixed snapping of rotation in the edge-on case

Review Request #608 - Created Nov. 26, 2012 and updated

Cron Stardust Reviewers
viewer
STORM-1919
None viewer-release
Simply had to guard the snapping code, making sure that the last "else" case was preserved when either the outer or the inner tests failed.

Careful analysis and testing was performed to determine what clauses could/should be inside the guarding if statement, which led to the discovery that the else clause had to be preserved outside under a separate test.  Code structure was carefully designed to match the other llManip* classes in similar areas.
Tested all rotation cases (edge-on & facing multiplied with snapping enabled & disabled) in Firestorm - however this area of code has not been modified in either viewer since ancient times and should therefore cause no ill effects.

Diff revision 1 (Latest)

  1. doc/contributions.txt: Loading...
  2. indra/newview/llmaniprotate.cpp: Loading...
doc/contributions.txt
Revision 9505109727a3e948b11564910fd58ee93503b3df New Change
... 303 lines hidden [Expand]
304
Coaldust Numbers
304
Coaldust Numbers
305
    VWR-1095
305
    VWR-1095
306
Colpo Wexler
306
Colpo Wexler
307
Corinne Helendale
307
Corinne Helendale
308
Corro Moseley
308
Corro Moseley
309
Coughdrop Littlething
309
Coughdrop Littlething
310
Cron Stardust
310
Cron Stardust
311
	VWR-10579
311
	VWR-10579
312
	VWR-25120
312
	VWR-25120
313
	STORM-1075
313
	STORM-1075

   
314
	STORM-1919
314
Cypren Christenson
315
Cypren Christenson
315
	STORM-417
316
	STORM-417
316
Dante Tucker
317
Dante Tucker
317
Dale Glass
318
Dale Glass
318
	VWR-120
319
	VWR-120
319
	VWR-560
320
	VWR-560
320
	VWR-2502
321
	VWR-2502
321
	VWR-1358
322
	VWR-1358
322
	VWR-2041
323
	VWR-2041
323
Darien Caldwell
324
Darien Caldwell
... 1004 lines hidden [Expand]
indra/newview/llmaniprotate.cpp
Revision 9505109727a3e948b11564910fd58ee93503b3df New Change
 
  1. doc/contributions.txt: Loading...
  2. indra/newview/llmaniprotate.cpp: Loading...