JavaScript is turned off

Review Board requires JavaScript in order to function. Please turn it on in your browser preferences.

Firefox users: if you prefer to turn on JavaScript only for specific sites, we recommend the NoScript extension.


Submitter:	MartinRJ Fayray	Reviewers
Branch:	3.4.0	Groups:	viewer
Bugs:	STORM-1911	People:
Change Number:	None	Repository:	viewer-release

Description:

Repository is here: https://bitbucket.org/MartinRJ/storm-1911

I more or less cloned the search-function and modified the floater via xml (new file: floater_goto_line.xml) to fit for a 'go to line' floater.
Also I added a callback to prevalidate the input in the 'go to line' line-editor, so that only numbers can be entered into it.

Testing Done:

Tested on my local PC with a modded "3.3.4-release3" version.
Open a script with at least 300 lines inside inventory, go to menu 'Edit-> go to line', enter a number less than 300 into the 'Go to' - field. Expected result: the cursor jumps to the entered line number (column 0).
Repeat the test with a script inside an object's content.

Expand All

Tested it in a viewer-development based build. Works fine for scripts in my inv as well as for scripts in objects.
One thing though, hitting enter when entering the line number shgould be enough, clicking the ok button is a bit of a pain.

MartinRJ Fayray Sept. 11, 2012, 7:02 p.m. (Sept. 11, 2012, 7:02 p.m.)

I wanted to keep the design close to the 'search' function. I know you are right about the Enter key, and I am missing that feature in the Search box, as well.
It would be cool if we could add that to both, the 'search' and the 'goto' window. Let's talk at the next UG meeting with Oz about that.
Thank you much for testing this / and your feedback.

Diff
- added Diff r2

Description:

Added the proposed changes(kelly and lance): jumping to the next match on commit (search-and-replace-floater); jump to the line and close on commit (goto-floater).

Branch changed from 3.3.4 to 3.4.0

Diff
- added Diff r3

Description:

Fix: The current selection needs to be deselected before I can move the cursor to it's new position.

indra/newview/llpreviewscript.cpp (Diff revision 3)

Please put new classes in a new file. (Don't mimic my bad code from years ago, please. :) )

indra/newview/llpreviewscript.cpp (Diff revision 3)

Need null checks on mEditorCore and mEditor

indra/newview/llpreviewscript.cpp (Diff revision 3)

Need null checks on mEditorCore, mEditor and sInstance

indra/newview/llpreviewscript.cpp (Diff revision 3)

minor note: This comment is backwards from the code - you describe the unwritten else case instead of the implemented if case. It confused me at first. Something like '// only deselect, setfocus and close if the cursor actually moved' would match the code written, or moving the comment to after the if block with something like '// else do nothing <etc>'

indra/newview/llpreviewscript.cpp (Diff revision 3)

Need null pointer checks on mEditorCore and mEditor.

Diff
- added Diff r4

Description:

I moved LLFloaterGotoLine into a new class file (llfloatergotoline.cpp with the header file llfloatergotoline.h), according to Kelly's review (and updated CMakeLists.txt),
added some null-checks in LLFloaterGotoLine and LLFloaterScriptSearch,
and I set "setCommitOnFocusLost" to FALSE (for the lineeditor in LLFloaterGotoLine::postBuild / LLFloaterScriptSearch::postBuild), to prevent unexpected commits/search.

Description

Changed from:

Repository is here: https://bitbucket.org/MartinRJ/bug-59

I more or less cloned the search-function and modified the floater via xml (new file: floater_goto_line.xml) to fit for a 'go to line' floater.
Also I added a callback to prevalidate the input in the 'go to line' line-editor, so that only numbers can be entered into it.

Changed to:

Repository is here: https://bitbucket.org/MartinRJ/storm-1911

I more or less cloned the search-function and modified the floater via xml (new file: floater_goto_line.xml) to fit for a 'go to line' floater.
Also I added a callback to prevalidate the input in the 'go to line' line-editor, so that only numbers can be entered into it.

Description:

New repository: https://bitbucket.org/MartinRJ/storm-1911

Summary changed from BUG-59: Go-to line function for the internal LSL script editor to STORM-1911: Go-to line function for the internal LSL script editor
Bugs Closed
- removed BUG-59
- added STORM-1911

Description:

Updated Jira-URLs to point to STORM-1911 instead.

Ship It!

You have a pending review.

Other reviews

Your comment

Review Board 1.6.11

STORM-1911: Go-to line function for the internal LSL script editor