All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

STORM-1911: Go-to line function for the internal LSL script editor

Review Request #596 - Created Sept. 11, 2012 and updated

MartinRJ Fayray Reviewers
3.4.0 viewer
STORM-1911
None viewer-release
Repository is here: https://bitbucket.org/MartinRJ/storm-1911

I more or less cloned the search-function and modified the floater via xml (new file: floater_goto_line.xml) to fit for a 'go to line' floater.
Also I added a callback to prevalidate the input in the 'go to line' line-editor, so that only numbers can be entered into it.
Tested on my local PC with a modded "3.3.4-release3" version.
Open a script with at least 300 lines inside inventory, go to menu 'Edit-> go to line', enter a number less than 300 into the 'Go to' - field. Expected result: the cursor jumps to the entered line number (column 0).
Repeat the test with a script inside an object's content.

Diff revision 3

This is not the most recent revision of the diff. The latest diff is revision 4. See what's changed.

1 2 3 4
1 2 3 4

  1. doc/contributions.txt: Loading...
  2. indra/newview/llpreviewscript.h: Loading...
  3. indra/newview/llpreviewscript.cpp: Loading...
  4. indra/newview/skins/default/xui/en/floater_goto_line.xml: Loading...
  5. indra/newview/skins/default/xui/en/panel_script_ed.xml: Loading...
doc/contributions.txt
Revision 7a056d7afeb2 New Change
... 732 lines hidden [Expand]
733
Manx Wharton
733
Manx Wharton
734
march Korda
734
march Korda
735
	SVC-1020
735
	SVC-1020
736
Marc Claridge
736
Marc Claridge
737
Marc2 Sands
737
Marc2 Sands
738
Marianne McCann
738
Marianne McCann
739
Marine Kelley
739
Marine Kelley
740
    STORM-281
740
    STORM-281
741
MartinRJ Fayray
741
MartinRJ Fayray
742
    STORM-1845
742
    STORM-1845

   
743
    BUG-59
743
Matthew Anthony
744
Matthew Anthony
744
Matthew Dowd
745
Matthew Dowd
745
	VWR-1344
746
	VWR-1344
746
	VWR-1651
747
	VWR-1651
747
	VWR-1736
748
	VWR-1736
748
	VWR-1737
749
	VWR-1737
749
	VWR-1761
750
	VWR-1761
750
	VWR-2681
751
	VWR-2681
751
Matto Destiny
752
Matto Destiny
752
Maxim RiversRunRed
753
Maxim RiversRunRed
... 563 lines hidden [Expand]
indra/newview/llpreviewscript.h
Revision 7a056d7afeb2 New Change
 
indra/newview/llpreviewscript.cpp
Revision 7a056d7afeb2 New Change
 
indra/newview/skins/default/xui/en/floater_goto_line.xml
New File
 
indra/newview/skins/default/xui/en/panel_script_ed.xml
Revision 7a056d7afeb2 New Change
 
  1. doc/contributions.txt: Loading...
  2. indra/newview/llpreviewscript.h: Loading...
  3. indra/newview/llpreviewscript.cpp: Loading...
  4. indra/newview/skins/default/xui/en/floater_goto_line.xml: Loading...
  5. indra/newview/skins/default/xui/en/panel_script_ed.xml: Loading...