STORM-1404 Light viewer: untranslated buttons in the People panel


Submitter:	Vadim ProductEngine	Reviewers
Branch:		Groups:	viewer
Bugs:	STORM-1404	People:
Change Number:	None	Repository:	viewer-development

Description:

Bug reason: incorrect reuse of an xml element name.
Fix: provided unique names for the buttons.

Testing Done:

Expand All

Looks like a duplicate of https://codereview.secondlife.com/r/387 which deals with STORM-1403, the issue caused by the same widget naming problem.

indra/newview/skins/minimal/xui/da/panel_people.xml (Diff revision 1)

share_btn doesn't occur (yet?/anymore?) in the English original, so I think it should be removed from the translations, too, to be consistent.

(Ditto for languages other than 'da')

Vadim ProductEngine July 25, 2011, 10:02 a.m. (July 25, 2011, 10:02 a.m.)
```
It's up to the translation team to remove obsolete translations.
```

> It's up to the translation team to remove obsolete translations.

In that case, no further concerns. Should we file a jira issue to make the translation team aware of the obsolete elements?

Vadim ProductEngine July 25, 2011, 12:21 p.m. (July 25, 2011, 12:21 p.m.)
```
Not sure whether it makes sense. I'll find out.
```

Vadim ProductEngine July 26, 2011, 2:25 p.m. (July 26, 2011, 2:25 p.m.)

So, their localization tool does detect obsolete translations, but only when the "en" file changes.
If you want to get rid of them earlier, please feel free to file a jira.

You have a pending review.

Other reviews

Your comment

Review Board 1.6.11

This change has been marked as submitted.