All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

STORM-1521 [previously VWR-25588]: Zi's proposed fix for FIRE-543 - Hovertext renders as overlay on top of everything else

Review Request #405 - Created July 21, 2011 and submitted

Boroondas Gupte Reviewers
viewer
SH-489, VWR-24017, VWR-25588
None viewer-development 
Set the z (depth) coordinate of hovertext such that the hovertext gets occluded by stuff in front of it.
Merged this change with e67da2c6e312 (as I still cannot build viewer-development tip) and rebuilt. Verified that my nametag and an objects llSetText hovertext were correctly occluded by another object in front of them.
Review request changed
Updated (July 21, 2011, 2:55 a.m.)
Made in-code comment a bit clearer.
Ship it!
Richard Nelson
Posted (July 28, 2011, 6 p.m.)
Looks good
Ship it!
ardy.lay
Posted (July 28, 2011, 6:27 p.m.)
I am using it without noticing any functional issues.  Does this return floating text and nametags to a previous behavior I haven't seen for a long time?  I think it does.  It feels comfortable to me and really decluters the display.
  1. > Does this return floating text and nametags to a previous behavior I haven't seen for a long time?
Yes, that's what it's supposed to do. See the linked SL jira issues and http://jira.phoenixviewer.com/browse/FIRE-543 (and duplicates there).