STORM-785 CTRL-\ Last chatter
Review Request #16 - Created Dec. 13, 2010 and submitted
| Jonathan Yap | Reviewers | ||
| viewer | |||
| STORM-785 | |||
| None | viewer-development | ||
You have to push CTRL-\(there is a menu item for this too) twice to get the last chatter function to work. My fix unlocks the camera before moving it.
Expand AllLooks plausible and works for me.
Review request changed
Updated (Dec. 14, 2010, 7:03 a.m.)
-
- added vwr-20962
added jira link
Posted (Dec. 16, 2010, 9:32 a.m.)
I suppose that there is a problem with the API, as that seems to dictate that the correct way to fix this is to first call setFocusOnAvatar(FALSE, FALSE) to unlock(?) or at least to stop the second call from calling setFocusGlobal, then to call setFocusGlobal and finally calling startCameraAnimation() to start the animation. Or maybe the last call isn't even needed since LLAgentCamera::setFocusGlobal also calls it. I'm not sure, but it would be my guess that calling setFocusOnAvatar(FALSE, FALSE) (in the same place as you do now, before calling setFocusGlobal) is the more correct solution: you don't want to start an animation at this point, you just want to stop focussing on the avatar. Can you try if that works too (Change the last TRUE into a FALSE)?
Review request changed
Updated (Dec. 22, 2010, 11:18 a.m.)
-
- added Diff r2
Aleric showed me a slight optimization in the two function calls I moved to fix this issue. In llagentcamera.cpp: setFocusoOnAvatar(FALSE, FALSE) (was FALSE, TRUE)
Review request changed
Updated (Dec. 22, 2010, 11:21 a.m.)
- changed from VWR-20962 CTRL-\ Last chatter to STORM-785 CTRL-\ Last chatter
Other reviews