All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

VWR-24520: Don't use pkg_check_modules( ... QUIET ) on CMake < 2.8.2

Review Request #97 - Created Jan. 17, 2011 and submitted

Boroondas Gupte Reviewers
viewer
VWR-24520
None viewer-development 
Only use QUIET in pkg_check_modules() on CMake >=2.8.2 (where it's supported) rather than already on CMake >=2.8.
Configured (standalone) without a .pgk file for libllqtwebkit on Linux with CMake 2.8.1 and CMake 2.8.3. Output as expected.

Not tested:
* CMake 2.8.2
* system with a .pgk file for libllqtwebkit
* non-standalone
* Mac, Win
Ship it!
Aleric Inglewood
Posted (Jan. 17, 2011, 12:35 p.m.)
Perfect ;)
Ship it!
Merov Linden
Posted (Jan. 20, 2011, 11:33 p.m.)
I'm advising the MM to merge in a test repo and do a full TC cycle on all platforms before merging though...
  1. As far as I can see indra/cmake/FindLLQtWebkit.cmake only gets called by indra/cmake/WebKitLibPlugin.cmake (through find_package(LLQtWebkit REQUIRED QUIET)), and there the call only happens for STANDALONE. So I would be very surprised if this affects TC builds.
  2. Any results from that TC cycle?