VWR-24317: Incorrect start up warnings: WARNING: remove: Attempting to remove filename: /ramdisk/imprudence/cache/textures/*/*.texture
Review Request #84 - Created Jan. 14, 2011 and submitted
| Aleric Inglewood | Reviewers | ||
| viewer | |||
| VWR-24317 | |||
| None | viewer-development | ||
This turned out to be a simple matter of trying to remove non-existant files: A texture with a 'body size' of 0 doesn't have a texture body file.
Expand AllPosted (Jan. 14, 2011, 2:03 p.m.)
-
indra/newview/lltexturecache.cpp (Diff revision 1) -
As this will sometimes stay true, even when the file doesn't exist, file_must_be_removed or delete_the_file might be better names. (Maybe you can think off even better ones.)
-
indra/newview/lltexturecache.cpp (Diff revision 1) -
Make this LL_WARNS("TextureCache") << "Entry has a body size of zero but file " << filename << " exists. This file will be deleted, too." << LL_ENDL; or similar.
Review request changed
Updated (Jan. 16, 2011, 6:12 a.m.)
-
- added Diff r2
Renamed the variable to 'file_maybe_exists', which should cover its meaning more accurately, thanks!
Changed the warning into
LL_WARNS("TextureCache") << "Entry has body size of zero but file " << filename << " exists. Deleting this file, too." << LL_ENDL;
The second part is the 'resolution' of the problem. Your proposal sounded a bit too much as if the warning was about the fact that the file was being removed...
Other reviews