VWR-24317: Incorrect start up warnings: WARNING: ll_apr_warn_status: APR: No such file or directory


Submitter:	Aleric Inglewood	Reviewers
Branch:		Groups:	viewer
Bugs:	VWR-24317	People:
Change Number:	None	Repository:	viewer-development

Description:

At start up one can get the following “warnings”:

2010-10-23T12:22:44Z WARNING: ll_apr_warn_status: APR: No such file or directory
2010-10-23T12:22:44Z WARNING: remove: Attempting to remove filename: /home/aleric/.imprudence/logs/Imprudence.logout_marker
2010-10-23T12:22:44Z WARNING: ll_apr_warn_status: APR: No such file or directory
2010-10-23T12:22:44Z WARNING: remove: Attempting to remove filename: /home/aleric/.imprudence/logs/Imprudence.llerror_marker
2010-10-23T12:22:44Z WARNING: ll_apr_warn_status: APR: No such file or directory
2010-10-23T12:22:44Z WARNING: remove: Attempting to remove filename: /home/aleric/.imprudence/logs/Imprudence.error_marker

This is nonsense since it is perfectly ok when those files don’t exist.

Testing Done:

Expand All

Looks good. Files should only be removed when they actually exists, which this change accomplishes.


Just wondering:

indra/newview/llappviewer.cpp (Diff revision 1)

what's the reason for moving the LL_INFOS around?

Aleric Inglewood Jan. 16, 2011, 6:17 a.m. (Jan. 16, 2011, 6:17 a.m.)

The last two, in order to print the correct value that gLastExecEvent is being set to: depending on the conditional, the value is set to what was printed, or to another value. The first hunk to have more symmetric code and treat that part the same as the others: first set the variable and then print it's contents.

Boroondas Gupte Jan. 16, 2011, 6:24 a.m. (Jan. 16, 2011, 6:24 a.m.)
```
Makes sense.
```

You have a pending review.

Other reviews

Your comment

Review Board 1.6.11

This change has been marked as submitted.