All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

VWR-13040: LLObjectSelection::valid_root_begin() is really the same as LLObjectSelection::root_begin()

Review Request #79 - Created Jan. 14, 2011 and submitted

Aleric Inglewood Reviewers
viewer
VWR-13040
None viewer-development 
See https://jira.secondlife.com/browse/VWR-13040

Been using this ever since that jira/patch was created.
Merov Linden
Posted (Jan. 14, 2011, 2 p.m.)
The patch is correct but, grepping the code, I can't see one instance of is_valid_root being used so, that fix is moot. Better maybe to suppress that struct altogether or may be start to use it where adequate (haven't looked at that aspect I need to confess).
Ship it!
Merov Linden
Posted (Jan. 14, 2011, 2:02 p.m.)
Ack... sorry: there are instances using the valid_root_iterator, silly me.
Ship it! It's clearly a cut/paste that didn't get modified.