All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

VWR-24420: PNG images which specify "background color" lose alpha layer when imported.

Review Request #74 - Created Jan. 9, 2011 and submitted

Thickbrick Sleaford Reviewers
viewer
VWR-24420
None viewer-development 
Current code composites RGBA PNG images that contain a bKGD chunk down to RGB, discarding the alpha channel. This patch removes that code, since it contradicts purpose of the bKGD chunk as described in the PNG spec and as commonly used.
Tested uploading the 2 images attached to VWR-24420 with and without the patch. Before patch, "bad alpha.png" was uploaded as RGB, after patch, both images were uploaded as RGBA.
Ship it!
Oz Linden
Posted (Jan. 17, 2011, 7:28 a.m.)

   

  

   

   
    
    
   


  






  
 




  

 

















 

  




 

 

  
  

  
Merov Linden

  
Posted  (Jan. 18, 2011, 11:11 a.m.)

 

 

   

   

  

   

   
    
    
   


  






   







    

     
     

      

       
        

         
          indra/llimage/llpngwrapper.cpp
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    

     
Typo : change "gama" to "gamma"


     

  

   

   
    
    
   


  





    

    

   


  
 




  

 



















 

  




 

 

  
Ship it!

  

  
Merov Linden

  
Posted  (Jan. 18, 2011, 11:12 a.m.)

 

 

   
Other than the typo, no problem with that code. Good to fix all those alpha upload scenarios.