VWR-24347 Reversion in Copy3rdPartyLibs.cmake -- cannot find msvc* files using VS 2005 Express
Review Request #68 - Created Dec. 29, 2010 and submitted
| Jonathan Yap | Reviewers | ||
| 2.5 | viewer | ||
| vwr-24347 | |||
| None | viewer-development | ||
Environment: Windows, VS 2005 Express Back in the days of v2.1 I was able to supply the following option to develop.py, which would allow me to specify the location of msvcr80.dll msvcp80.dll Microsoft.VC80.CRT.manifest -DMSVC_REDIST_PATH:PATH=E:/some/path There was a similar code path for the debug files -DMSVC_DEBUG_REDIST_PATH=E:/some/path This files cannot be found by the Express compiler so without a way of telling the compiler where to find them they have to be dropped into the build tree manually. At some point Copy3rdPartyLibs.cmake was rewritten and this option was dropped.
I tried using -DMSVC_REDIST_PATH:PATH=E:/some/path with my VS 2005 Express compiler and obtained the desired result. I don't have the debug files to test -DMSVC_DEBUG_REDIST_PATH=E:/some/path
Expand AllPosted (Jan. 3, 2011, 3:24 p.m.)
Could you identify in the log history of the file when that "at some point" happened? There might be a reason for it though I can't imagine one off the top of my head.
Posted (Jan. 4, 2011, 4:14 p.m.)
Those lines have been missing since a long time: the first version in hg is already missing them: https://bitbucket.org/lindenlab/viewer-development/changeset/07304583316d
Posted (Jan. 17, 2011, 7:33 a.m.)
Given that we are in the process of moving to VS2010, I suggest that this is not worth doing
Other reviews