All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

Reenable the LLMatrix3::orthogonalize test in llmath/tests/m3math_test.cpp

Review Request #67 - Created Dec. 28, 2010 and submitted

Wolfpup Lowenhar Reviewers
default viewer
https://jira.secondlife.com/browse/VWR-24332
None viewer-development 
This patch is to fix this test is working in Windows environments
Re-enabled the test and built the viewer including all tests and have no errors and all of the test done in m3math_test are reporting that they all succeed.
Review request changed
Updated (Dec. 28, 2010, 10:05 a.m.)

  • This patch is to fix https://jira.secondlife.com/browse/VWR-24332 this test is working in Windows environments

    This patch is to fix this test is working in Windows environments
move location of link to jira
Aleric Inglewood
Posted (Dec. 28, 2010, 10:10 a.m.)
I think this line should be deleted, not commented out. If there still is a reason to think that it might need to be uncommented later than apparently we aren't sure the test really works, in which case I think it should be skipped until we are certain and this is fixed on all platforms.
  1. I agree: Delete the line, don't just comment it out. The fact that it was once there will be preserved in the revision history, which should be sufficient.