All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.
Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.
Review Request #618 - Created April 11, 2013 and updated
| Nicky Perian | Reviewers | ||
| viewer | |||
| OPEN-172 | |||
| None | viewer-development | ||
OPEN-172 Combined changesets for Linux gcc 4.7,2 build of viewer development
Built on debian wheezy virtual box virtual machine. Logged on secondlife. Checked logs and found no spamming. Do not have a native machine to test with. The change to llviewertexture.cpp around line 419 needs a close look.
| indra/newview/llviewertexture.cpp (Diff revision 1) |
|---|
Ugg, took me awhile to find this. The fix is to declare a virtual destructor on LLTextureManagerBridge in lltexturemanagerbridge.h. Looks like it can be pure virtual.
Built on debia wheezy virtual box virtual machine. Logged on secondlife. Checked logs and found no spamming. Do not have a native machine to test with. The change to llviewertexture.cpp around line 419 needs a close look.
Built on debian wheezy virtual box virtual machine. Logged on secondlife. Checked logs and found no spamming. Do not have a native machine to test with. The change to llviewertexture.cpp around line 419 needs a close look.
Added virtual destructor, returned llviewertexture.cpp to original.
Added conditional around new std=c++11 code that would cause build problem on Darwin and Windows and Linux without std=c++11.
Expand All
Other reviews