All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

BUG-840: Viewer 3.4.2 (Beta) breaks almost every sliding door script in SL

Review Request #616 - Created Feb. 15, 2013 and updated

MartinRJ Fayray Reviewers
viewer-release viewer
BUG-840
None viewer-release
Fixes missing childprim- position/rotation-updates when the avatar was 20+m away and didn't have the object in view when it was changed.


Repository: https://bitbucket.org/MartinRJ/bug-840
Create an object with two prims, add a script with a listener on PUBLIC_CHANNEL and make it change the relative position of the child prim in the listen-event.

Move the avatar 20+ m away from the test object, and look in the opposite direction, so that the object is not in view.

Shout something in public chat so that the child prim changes its relative position.

Turn around so that the test object is in view again.

Expected result: the prims visibly changed.

Without this fix, the child prim would not update its position (or rotation).

This fix has to be tested against the following related bugs:
BUG-840 [positionbug], BUG-840: Viewer 3.4.2 (Beta) breaks almost every sliding door script in SL
MAINT-2275 [vehiclebug],  Child prims are "left behind" by animated, moving physical objects
MAINT-1742 [selection], Child object does not update position while selected.
MAINT-2247 [selection]  Child object does not update rotation while selected.
Review request changed
Updated (Feb. 16, 2013, 11:25 p.m.)
Did some cleanup.