All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

OPEN-159 / Faster, nicer Depth of Field

Review Request #615 - Created Jan. 11, 2013 and updated

Tofu Buzzard Reviewers
tofu_linden/faster-dof viewer
OPEN-159
None viewer-development
This turns on bilinear filtering of the composited screen buffer used as the colour source for the depth-of-field effect (and its downscaled version).
This simply means that we can get away with around half as many samples for the same quality of bokeh effect.  The samples we do take express the desired radius more accurately too, so there aren't such glaring delineations in blurredness.

To celebrate being about twice as fast, I've also upped the maximum fatness of the bokeh effect for situations of extreme defocus.  So typical cases are around twice as fast, and the extreme bokeh situation is around the previous speed but with fatter highlights.
Been running like this for a while myself...
Review request changed
Updated (Jan. 11, 2013, 2 p.m.)
Posted (Jan. 11, 2013, 2:03 p.m.)

   

  
indra/llrender/llpostprocess.cpp (Diff revision 1)
 
 
Ah, yes.  I added this assert to mark this function as broken because it ate some of my time just unobviously doing nothing.
Posted (Jan. 22, 2013, 9:41 a.m.)
See problem report in Jira at https://jira.secondlife.com/browse/STORM-1927?focusedCommentId=362619&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-362619