Put the viewer version into marker files, and report errors only when the version matches


Submitter:	Oz Linden	Reviewers
Branch:		Groups:	viewer
Bugs:	storm-1850	People:	callum
Change Number:	None	Repository:	viewer-beta

Description:

In all the marker files used to detect how the viewer run terminates, record the version.  When checking the results, report errors only if the current version matches the version in the file.  This prevents errors in one version from being reported against the subsequent version.

Testing Done:

Several simulated crashes both of the modified and unmodified viewers, and some in which the marker file was modified manually to simulate different viewers. Launched the new viewer after different crashes (and normal exits) and confirmed (using logging temporarily added for that purpose) that the reported last exec event was correct - and is always reported as Normal if the previous version and the running version were not the same.

Expand All

Reviewers (People)
- added callum

Functionally, it looks good...just one minor comment about structure

indra/newview/llappviewer.cpp (Diff revision 1)

Structurally, it seems like this would be cleaner if opening the file, writing out the marke version, and closing it all happened in one function.  Otherwise, you have this constraint that the file needs to be opened before being passed into recordMarkerVersion and closed afterwards.

Just picking a nit, sorry.

Oz Linden Nov. 9, 2012, 2:50 p.m. (Nov. 9, 2012, 2:50 p.m.)

I didn't do that because the usage of the two marker files is so different: the exec marker file is locked, but the logout marker file is not; and there is at least one code path in which the logout marker file is (apparently deliberately) not closed at all.

Richard Nelson Nov. 9, 2012, 2:54 p.m. (Nov. 9, 2012, 2:54 p.m.)
```
Hmmm, ok.  Fair enough.
```

status changed from pending to submitted

You have a pending review.

Other reviews

Your comment

Review Board 1.6.11

This change has been marked as submitted.