STORM-524 : Refresh L$ balance
Review Request #6 - Created Dec. 8, 2010 and submitted
| Merov Linden | Reviewers | ||
| https://bitbucket.org/lindenlab/viewer-beta | viewer | ||
| STORM-524 | |||
| None | viewer-beta | ||
Since the L$ balance can be updated by events outside the viewer entirely (purchase of L$ on web) and since we do not pool or receive notifications for this, I implemented a simple "click to refresh" event on the LLTextBox holding the L$ balance value (proposed by Q in JIRA). I modified the tooltip to reflect this new functionality.
Expand AllLooks fine to me.
Posted (Dec. 9, 2010, 5:46 a.m.)
This will be a much appreciated feature as it means residents will no longer have to request someone send them a single L$ to force a refresh as the will be able to do it themselves simply by clicking on their balance.
Didn't test, but code looks good.
-
indra/newview/llstatusbar.cpp (Diff revision 1) -
consider to break long comments onto several lines
Other then that, go for it!
Review request changed
Updated (Dec. 9, 2010, 11:55 a.m.)
-
- added Diff r2
I added some LLStatusBar::sendMoneyBalanceRequest() calls in few L$ UI that didn't do it. Hope it'll catch them all.
Posted (Dec. 10, 2010, 12:23 a.m.)
Merov, why do we need those added calls? And the one in draw() looks suspicious to me: are you sure it won't be ever called, say, 100 times per second?
Review request changed
Updated (Dec. 10, 2010, 4:21 p.m.)
-
- added Diff r3
Took Vadim's comment into account pulling the balance update out of updateUI() and only in onClick() calls or close UI calls
No more objections.
> 99% chance that this is correct (not counting the added line with trailing white space ;).
Something that can impossibly be harmful, but what made me wonder, is that before
getChild<LLTextBox>("balance") never has setVisible called in the old code, but
in the new code apparently needs it (definitely looking logical from the context
where it is added). But I suppose that it's irrelevant.
Other reviews