STORM-1899: Avatar hand poses randomly get stuck in spread position


Submitter:	Ansariel Hiller	Reviewers
Branch:		Groups:	viewer
Bugs:	STORM-1899	People:
Change Number:	None	Repository:	viewer-release

Description:

A proposed solution for STORM-1899 and the issue, where the handpose of avatars randomly get stuck in the spread hand position.

In the current implementation, this case might happen under the following circumstances:
* Avatar uses an animation with hand pose A
* A request is issued to change hand pose to B
* Before the viewer has blended pose A over to pose B, the original pose A is requested again
* In this case, the hand pose will not be properly (re)set and because mNewPose == mCurrentPose, there will be no further blending, leaving the hand in it's current pose

The patch will properly reset the hand pose in this case and update the visual parameters of the avatar.

Testing Done:

Expand All

Summary changed from Fix VWR-1793: Avatar hand poses randomly get stuck in spread position to STORM-1899: Avatar hand poses randomly get stuck in spread position

Description:

Changed summary to reflect correct JIRA issue.

indra/llcharacter/llhandmotion.cpp (Diff revision 1)

you probably don't want to write to this memory if you are getting bad values.  Best to warn and then do nothing.

Ansariel Hiller July 20, 2012, 4:47 a.m. (July 20, 2012, 4:47 a.m.)

So your idea is to skip the remaining part of the else block where the new value for mNewPose is set and continue with the old value of mNewPose?

Diff
- added Diff r2

Description:

Updated the diff based on Richard's comment. The new hand pose is only set if the requested pose is valid (*requestedHandPose => 0 && *requestedHandPose < NUM_HAND_POSES). If it's invalid, it is only logged and the hand motion update continues with the current pose.

Ship It!

I think the warning message should either go, or be modified to warn only once, or be changed to lldebug... the way it is now it floods the logfiles... i have 1900 repeats of that warning line in my log file, after being logged in for less than 5 minutes!

Lance Corrimal July 29, 2012, 1:24 a.m. (July 29, 2012, 1:24 a.m.)

on second thought, this flooding might be because I screwed up my test build...

... yep, that was it.

Ship It!

status changed from pending to submitted

You have a pending review.

Other reviews

Your comment

Review Board 1.6.11

This change has been marked as submitted.