All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

STORM-1879: Inventory gear menu remains on screen after floater is closed

Review Request #588 - Created June 24, 2012 and submitted

MartinRJ Fayray Reviewers
3.3.3 viewer
STORM-1879
None viewer-release
Hide menus when the closed floater has focus.
Added a check whether a "VisibilityChange"-action was triggered via shortcut.

Repository: https://bitbucket.org/MartinRJ/storm-1879
See test plan in JIRA: https://jira.secondlife.com/browse/STORM-1879

Diff revision 2 (Latest)

1 2
1 2

  1. indra/llui/llfloater.cpp: Loading...
  2. indra/llui/lltoggleablemenu.cpp: Loading...
indra/llui/llfloater.cpp
Revision 4d9106153407 New Change
... 740 lines hidden [Expand]
void LLFloater::closeFloater(bool app_quitting)
741

   
741

   
742
			// give focus to dependee floater if it exists, and we had focus first
742
			// give focus to dependee floater if it exists, and we had focus first
743
			if (isDependent())
743
			if (isDependent())
744
			{
744
			{
745
				LLFloater* dependee = mDependeeHandle.get();
745
				LLFloater* dependee = mDependeeHandle.get();
746
				if (dependee && !dependee->isDead())
746
				if (dependee && !dependee->isDead())
747
				{
747
				{
748
					dependee->setFocus(TRUE);
748
					dependee->setFocus(TRUE);
749
				}
749
				}
750
			}
750
			}

   
751
			// With focus, treat the closeFloater- call like a click on the close-button

   
752
                        // and close gear- and contextmenus.

   
753
			LLMenuGL::sMenuContainer->hideMenus();
751
		}
754
		}
752

   
755

   
753
		dirtyRect();
756
		dirtyRect();
754

   
757

   
755
		// Close callbacks
758
		// Close callbacks
756
		onClose(app_quitting);
759
		onClose(app_quitting);
757
		mCloseSignal(this, LLSD(app_quitting));
760
		mCloseSignal(this, LLSD(app_quitting));
758
		
761
		
759
		// Hide or Destroy
762
		// Hide or Destroy
760
		if (mSingleInstance)
763
		if (mSingleInstance)
... 2685 lines hidden [Expand]
indra/llui/lltoggleablemenu.cpp
Revision 4d9106153407 New Change
 
  1. indra/llui/llfloater.cpp: Loading...
  2. indra/llui/lltoggleablemenu.cpp: Loading...