STORM-1878: Blocking an avatar does not derender worn lights


Submitter:	MartinRJ Fayray	Reviewers
Branch:	3.3.2	Groups:	viewer
Bugs:	STORM-1878	People:	davep
Change Number:	None	Repository:	viewer-release

Description:

An avatar currently gets derendered/invisible when the user blocks it.
The local lights attached to that avatar have to become erased too.
Repository: https://bitbucket.org/MartinRJ/storm-1878

Testing Done:

Tested with 1-6 local attached lights on the target avatar.
Blocking/muting the avatar also disabled the attached lights in all tests successfully.

Expand All

Reviewers (People)
- added davep

No issues with the code so far, but from inspection I don't think this code will block lights for an avatar that is already muted -- it only blocks lights at the moment you mute another avatar.  You'll need to add a check to LLPipeline::setLight that verifies the object is not on the mute list before inserting the object onto gPipeline.mLights.

MartinRJ Fayray June 18, 2012, 12:06 p.m. (June 18, 2012, 12:06 p.m.)

Lights from an avatar that is already muted were blocked before, already. The adressed issue was that you had to teleport away and back to get rid of the lights.
I can't 100% tell that I'd really understand the magic behind, but that already worked before.
With this fix, the lights disappear instantly (without the need to teleport away/then back).

In that case, ship it!

status changed from pending to submitted

You have a pending review.

Other reviews

Your comment

Review Board 1.6.11

This change has been marked as submitted.