Fixes paste action in editor windows.


Submitter:	Ima Mechanique	Reviewers
Branch:	https://bitbucket.org/ImaMechanique/vwr-20553	Groups:	viewer
Bugs:	VWR-20553	People:
Change Number:	None	Repository:	viewer-release

Description:

Fixes paste action in editor windows (notecards, scripts, etc.) so that pasting text is a single action as far as Undo is concerned.
This is an updating of Satomi Ahn's patch to work with v3.3.1.

Testing Done:

Tried pasting/undoing.

Expand All

Branch changed from to https://bitbucket.org/ImaMechanique/vwr-20553

indra/llui/lltexteditor.h (Diff revision 1)

It would be much clearer when reading calls to this method if the parameter were an enum rather than a boolean.  Consider the readability difference between:
 addLineBreakChar(FALSE);
and
 addLineBreakChar(DoNotGroupLines);

Ima Mechanique May 13, 2012, 10:13 p.m. (May 13, 2012, 10:13 p.m.)

This would require additional, and IMO, inelegant code to set an additional boolean variable in the function.
A comment would make it equally, if not more, clear and not require unnecessary code or an enum.

Ima Mechanique May 13, 2012, 10:19 p.m. (May 13, 2012, 10:19 p.m.)

After adding the diff with comments, it occurred to me a constant could also be used.

addLineBreakChar(GROUP_LINES);

Diff
- added Diff r2

Description:

Updated diff, with comments, to address readability.

status changed from pending to submitted

You have a pending review.

Other reviews

Your comment

Review Board 1.6.11

This change has been marked as submitted.