All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

Don't save per-account settings if login not fully successful

Review Request #578 - Created May 1, 2012 and submitted

Jonathan Yap Reviewers
viewer
STORM-1842
None viewer-release 
The viewer resets your "per-account" settings when you try to log in too fast after a crash ("the region is logging you out") and then quit the viewer before a successful login.

See comment and link to fix in https://jira.secondlife.com/browse/STORM-1794?focusedCommentId=305543&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-305543

Repo:
Somehow crash your viewer

Try to log back in immediately: You get a message "The region is logging you out"

Quit the viewer at this point: your per-account settings are now zorched, as they were not yet read in, but are being written out.


 

 










  

 














 













 














 

  




 

   

   
Review request changed

   
Updated  (May 1, 2012, 10:06 a.m.)

 

 

  
    

   
  • 


changed from pending to submitted




   
    • 

  


 




  

 
















 

  




 

 

  
Ship it!

  

  
Boroondas Gupte

  
Posted  (May 1, 2012, 12:52 p.m.)

 

 

   
Just some nit-picky remark about the review request description: Please distinguish "repo" (short for 'repository') from "repro" (short for 'reproduction').