Do not create the build directory when --dry-run is specified
Review Request #575 - Created April 15, 2012 and submitted
| Oz Linden | Reviewers | ||
| OPEN-60 | nat_linden, mz | ||
| None | autobuild | ||
When --dry-run is specified, the command should not modify anything, including even not creating an empty build directory. This change also fixes the fact that --dry-run didn't work at all in the 'install' subcommand.
Expand AllShip It!
-
autobuild/configfile.py (Diff revision 1) -
I'm a little uneasy about pushing down the dry_run functionality into a fairly leaf-level method like ConfigurationDescription.make_build_directory(). If all we wanted to do was to skip the os.makedirs() call when dry_run is set, I'd almost be in favor of propagating the 'if' condition outward to callers. However, given the new logging calls, we don't actually want to clone that logic for every call -- we'd certainly want to encapsulate it somewhere. It may as well be here in this method.
Review request changed
Updated (April 16, 2012, 9:43 a.m.)
- changed from pending to submitted
Other reviews