All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

STORM-1807 Play animation floater 2nd play button active while animation is playing

Review Request #552 - Created Feb. 8, 2012 and submitted

Jonathan Yap Reviewers
3.3.0 viewer
STORM-1807
None viewer-development
Part 1
Open your inventory's Animations folder
Double click on an animation
Click on Play Inworld: Play Inworld is replaced by a Stop button

Observed behavior: It is still possible to click on Play Locally, which also is replaced by a Stop button. Clicking on either Stop works and resets the floater back to having both Play buttons showing.

Expected behavior: When one of the play buttons is clicked the other should be disabled.


Part 2
1 .To reproduce, get any non looping animation. ie, one that plays once and then stops.
2. Right click in inventory and select play in world.
3. The animation dialog appears with play locally and play in world buttons.
4. When the animation is playing, the play in world button changes to a stop button, which makes it stop playing.
Now here's the problem:
5. When the animation finishes of it's own accord, the button still says stop. To play it again, you have to click the redundant stop button to make it change back to Play in World, then click that to play again.

Expected behaviour, is that when an animation finishes, the stop button should change back of it's own accord. 
See test plan in jira.
Review request changed
Updated (May 18, 2012, 10:53 a.m.)
  • changed from pending to submitted