STORM-1793 1) Treat all mini-map altitudes above 1020 m as the same height 2) Improve z-level accuracy
Review Request #545 - Created Jan. 27, 2012 and submitted
| Jonathan Yap | Reviewers | ||
| 3.2.8 | viewer | ||
| STORM-1793 | |||
| None | viewer-development | ||
The SL simulator has recently been fixed so that the CoarseLocationUpdate message properly returns 255 for all altitudes above 1020 meters. The code for the mini-map, in drawing the agent locations for equal, above or below needs to take this into account. It currently does not. The routine that returns who is nearby can be enhanced to scan the character list and use that position data. This gives an accurate z-level value, even when above 1020m. In the case where the relative Z value between you and another avatar is unknown display an X on the mini-map.
See test plan in jira
Expand AllPosted (Feb. 3, 2012, 5:45 a.m.)
Don't apply the proposed changes to LLWorld::getAvatars()! There are other parts in the viewer that rely on being able to pass NULL either for the avatar_ids or positions parameter, for instance LLFloaterAvatarPicker::populateNearMe()
Review request changed
Updated (Feb. 3, 2012, 6:05 a.m.)
-
- added Diff r2
Fix bad assumption in getAvatars
Posted (Feb. 3, 2012, 8:39 a.m.)
-
indra/newview/llworld.cpp (Diff revision 2) -
This is not good. The avatar UUID won't be added if NULL is passed as positions vector. This needs to stay outside the if-clause.
Review request changed
Updated (Feb. 3, 2012, 8:51 a.m.)
-
- added Diff r3
Fixed another logic error in getAvatars. This code could be improved by changing one call into this method, so avatar_ids always has a matching positions parameter (which, erroneously, I thought it did).
-
indra/newview/llworld.cpp (Diff revision 3) -
When wrapping conditions across lines, I find it more clear to put the operators on the left: if ( condition1 && condition2 ...
Review request changed
Updated (Feb. 7, 2012, 6:28 a.m.)
-
- added Diff r4
Fix syntax error. Forgot to compile after making the last change. Dumb mistake.
Ship It!
Review request changed
Updated (April 9, 2012, 10:01 a.m.)
- changed from pending to submitted
Other reviews