All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

STORM-1804 Details... button on PERMISSION_DEBIT dialog triggers run_time_permissions() with a deny action

Review Request #544 - Created Jan. 25, 2012 and submitted

Jonathan Yap Reviewers
3.2.5 viewer
STORM-1804
None viewer-development
When an object requests DEBIT permissions a large, yellow dialog appears. This dialog has three buttons: "Grant", "Deny", and "Details..." When you select "Details..." Additional information about DEBIT permission is displayed.

The bug is that when "Details..." is selected PERMISSION_DEBIT is denied and the run_time_permissions() event handler is triggered. There is also a system message in the Local Chat pane of the communicate window that informs the user that permission has been denied. Further, if "Grant" or "Deny" are pressed AFTER details the run_time_permissions() event handler is NOT triggered, yet there is a system message saying that permissions have been granted or denied.

What should happen when "Details..." is pressed is no run_time_permissions event should be triggered and the "Grant" and "Deny" buttons should operate normally and trigger the run_time_permissions event afterwards.
See test script in jira.

Click on Details: additional information is shown, click on Ok to dismiss that, then you can go back and click on Grant or Deny.
Review request changed
Updated (April 9, 2012, 10:01 a.m.)
  • changed from pending to submitted