Having the tests in this order is what is needed.  There are two cases here: dealing with a muted session initiator has to take precendence over a muted non-initiator avatar in an existing session.

Not having the test for a linden was someone's oversight which I have corrected.  There are a few other instances of this check not being performed properly.  If you think fixing these now is within the scope of this jira please let me know.

I'm prepared to believe there's a difference here I don't see, but why isn't this:

	//ignore invites from muted residents
	if (LLMuteList::getInstance()->isMuted(caller_id) && !is_linden)
	{
            if (voice_invite && "VoiceInviteQuestionDefault" == question_type)
            {
    	        llinfos << "Rejecting voice call from initiating muted resident " << caller_name << llendl;
    	        LLIncomingCallDialog::processCallResponse(1, payload);
            }
	    return;
	}

I'm sorry, you are totally correct.  I was rushing trying to get these changes done quickly so you could have them for your test build and was still thinking of the logic changes I made elsewhere for the non-voice part of this fix.  I've adjusted the code per what you have above.