All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

STORM-1105 "Traffic: 0" shown for two cases (traffic actually 0, and waiting for data)

Review Request #509 - Created Oct. 28, 2011 and submitted

Jonathan Yap Reviewers
V3.2.1 viewer
STORM-1105
None viewer-development

In the past, the daily computation for "traffic" has failed to compute - see SVC-6142 - which results in showing "Traffic: 0" for parcels that have actually had visitors.

However, even if that has been addressed (and we believe it has), the viewer logic shows "Traffic: 0" for two cases:

    * Waiting for data from the server
    * Traffic actually is 0

Ideally, the viewer would distinguish these, e.g. showing "(waiting for data)" or some such, so that it is clear that the 0 is not an actual result in those cases.

This should be relatively easy to plumb into indra/newview/llviewerparcelmgr.cpp and indra/newview/llfloaterland.cpp
Opened About Land repeatedly, saw Loading... briefly before a numerical value for Traffic appeared.
Ship it!
Posted (Oct. 31, 2011, 2:32 a.m.)