STORM-1653 Group notices sent by muted residents are still displayed
Review Request #508 - Created Oct. 26, 2011 and submitted
| Jonathan Yap | Reviewers | ||
| 3.1.1 | viewer | ||
| STORM-1653 | |||
| None | viewer-development | ||
When I mute a resident, group notices from that resident are still being displayed to me.
See test plan in jira. Even with an empty name cache I still get an AgentID back. It is not clear to me if I might not when there is a cache miss and the backend systems servicing the name to ID request are heavily loaded.
Expand All-
indra/newview/llviewermessage.cpp (Diff revision 1) -
I don't think you can get a cache miss on a legacy name fetch, but in any case something should be logged here (I'd say at warning level).
Review request changed
Updated (Oct. 26, 2011, 11:09 a.m.)
-
- added Diff r2
Added a line to display a warning if the name to id routine returns a null.
Review request changed
Updated (Nov. 23, 2011, 6:57 a.m.)
-
- added Diff r3
Added a bit of code to handle the case of last name being "Resident".
Posted (Nov. 23, 2011, 7:23 a.m.)
-
indra/newview/llviewermessage.cpp (Diff revision 3) -
I suggest adding the name you were trying to look up to this log message: "buildLegacyName(" << legacy_name << ") did not find an agent_id"
Review request changed
Updated (Nov. 23, 2011, 8:05 a.m.)
-
- added Diff r4
Added more information to a LL_WARNS line per RB request.
Review request changed
Updated (Dec. 6, 2011, 8:47 a.m.)
-
- added Diff r5
Added affected name to warning message.
Ship It!
Ship It!
Review request changed
Updated (Jan. 11, 2012, 7:24 a.m.)
- changed from pending to submitted
Other reviews