All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

storm-1663: widen pitch clamping on camera, make it the same for sitting

Review Request #504 - Created Oct. 23, 2011 and submitted

Oz Linden Reviewers
viewer
storm-1663
None viewer-development 
See linked jira issue.   It's not yet clear why the existing limits were chosen, or why the limits were narrowed when sitting.

The changes here are essentially the same as the method used in Phoenix, so I don't expect anything catastrophic.

test viewer at http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_project-2/rev/243714/index.html
Review request changed
Updated (Oct. 23, 2011, 6:44 a.m.)

  • The changes here are essentially the same as the method used in Phoenix, so I don't expect anything catastrophic, but I'm building a test viewer to find out.

    The changes here are essentially the same as the method used in Phoenix, so I don't expect anything catastrophic.

test viewer at http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_project-2/rev/243714/index.html
Ship it!
Cron Stardust
Posted (Oct. 23, 2011, 1:45 p.m.)
Looks good to me.  The only issue I can see is commenting to why it's limited to 1 degree off the pure limit, so as to prevent this kind of confusion again.  My guess is to prevent gimbal lock - which could then be rectified a different way later in the future, for instance by eliminating the limits and using non-Euler angles to control the rotation allowing the user to rotate continuously in vertical direction like is done in the horizontal.