All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

Add experimental support for building with Xcode 4.2 on Mac OS X Lion

Review Request #502 - Created Oct. 18, 2011 and submitted

Stone Linden Reviewers
viewer
None viewer-development
Check the version of Xcode installed, and use that to set appropriate Mac OS X SDK and compiler versions.

Supports Xcode 3.2.x with Mac OS X SDK 10.5 with identical parameters as the code it replaces.
Adds parameters for Xcode 4.2 with Mac OS X 10.6 SDK.

Explicitly rejects with a message Xcode less than 3.2, and both 4.0 and 4.1.

Removes options for PPC builds, which we don't use, don't support, and don't work anyhow.
Builds On My Machine (TM).
Posted (July 15, 2012, 9:35 p.m.)
This has perfectly ran for me on xcode 4.3.3. I did end up changing.. 

+  if("${XCODE_VERSION}" VERSION_EQUAL "4.2"
+  OR "${XCODE_VERSION}" VERSION_GREATER "4.2")

too
+  if("${XCODE_VERSION}" VERSION_EQUAL "4.3"
+  OR "${XCODE_VERSION}" VERSION_GREATER "4.3") 
  1. I can confirm that this patch works with LL SL viewer release 3.4.0(0) source from bitbucket (forked 2012oct16), compiled with gcc 4.2.1 (Xcode 4.3.3, SDK for OS 10.6) on macbook pro running OS 10.7.4.    I needed to change some of the minus entries in the patch to match indra/cmake/Variables.cmake from the repository.   Reading the repository file after line 98 makes it obvious how to adjust.