STORM-959 Syntax highlighting for LSL multi-line comments.
Review Request #498 - Created Oct. 15, 2011 and submitted
| Ima Mechanique | Reviewers | ||
| viewer | |||
| STORM-959 | |||
| None | viewer-development | ||
Adding syntax highlighting for LSL multi-line comments. This has been sitting on my hard drive for months. I've redone the diff against current tip.
Expand AllPosted (Oct. 16, 2011, 6:32 a.m.)
Looks good as far as I can tell. Can we unit-test this somehow, though?
-
indra/llui/llkeywords.cpp (Diff revision 1) -
Code duplication. Could be worth factoring out an (inlined) compare function to be called with mToken in isHead and with mDelimiter in isTail.
-
indra/llui/llkeywords.cpp (Diff revision 1) -
Any reason to keep this line commented out instead of removing it entirely?
-
indra/llui/llkeywords.cpp (Diff revision 1) -
While we're here, this comment should start with 'If', not 'Is'
Review request changed
Updated (Oct. 16, 2011, 12:32 p.m.)
-
- added Diff r2
Updated diff to incorporate two of Boroondas' comments. Still looking at the main comment.
Review request changed
Updated (Oct. 16, 2011, 12:45 p.m.)
-
- added Diff r3
diff2 seemed to break something on RB.
Posted (Oct. 18, 2011, 8:47 a.m.)
-
indra/llui/llkeywords.h (Diff revision 3) -
Doxygen comments for the usage of these would be good. Per the coding standard, it should be a typedef: https://wiki.secondlife.com/wiki/Coding_Standard#Enums
-
indra/llui/llkeywords.h (Diff revision 3) -
getLength2 is not descriptive.... name it in a way that reflects the difference in what it does (and if making that clear requires renaming getLength, that's fine)
Review request changed
Updated (Oct. 25, 2011, 6:03 p.m.)
-
- added Diff r4
* Fixed the */ delimiter being ignored. FINALLY! * Changed enum to a typedef and added a doc-block. * Changed names of enum constants to be a little less confusing. * Renamed getLength()/getLength2() to be more informative [getLengthHead()/getLengthTail()].
Posted (Oct. 29, 2011, 9:43 p.m.)
-
.hgignore (Diff revision 4) -
why is this here? shouldn't this be a separate commit to exclude showing .diff files in hg working directory?
Other reviews