
Submitter:	Alain Linden	Reviewers
Branch:	http://bitbucket.org/alain_linden/autobuild	Groups:	viewer
Bugs:		People:	oz.linden, jenn, nat_linden
Change Number:	None	Repository:	autobuild

Description:

These changes are to support packaging archives as zip files. This is useful when you are using autobuild to construct an archive that isn't really intended to be used as an autobuild installable. Internally autobuild can handle tarballs on any platform, but if you are making a package for windows and not installing with autobuild, it is better to use zip which is natively supported. Changes here do the following:

1. enable the --archive-format option for autobuild package to choose the format of the package.
2. add support for reading an 'archive' entry per platform with the new 'format' element to select the archive format with the configuration file.
3. add new edit command 'autobuild edit archive' to add archive configurations.
4. add support for installing zip formatted archives.

Testing Done:

Diff revision 2 (Latest)

Jump to revision:	1 2
Changes between r2 and:	1 2

Files Changed:

--- Revision ac90b03614ea
+++ New Change
                 config.save()
         def _get_command_callables(self):
             """
             Lazily create arguments dict.
             """
             try:
                 self.arguments
             except AttributeError:
                 self.arguments = {
                                     'archive':      Archive,
                                     'configure':    Configure,
                                     'build':        Build,
                                     'package':      Package,
                                     'platform':     Platform,
                                     'source-info':  SourceInfo,
+                                }
             return self.arguments
     def _arg_help_str(args, arg_dict):
         def delete(self, name='', **kwargs):
             """
             Delete the named config value.
             """
             if not name:
                 raise AutobuildError("'name' argument must be provided with --delete option.")
             print "Deleting entry."
             self.config.package_description.platforms.pop(name)
     class Archive(InteractiveCommand):
         ARGUMENTS = ['format', 'hash_algorithm', 'platform']
         ARG_DICT = {    'format':             {'help':'Archive format (e.g zip or tbz2)'},
                         'hash_algorithm':  {'help':'The algorithm for computing the archive hash (e.g. md5)'},
                         'platform': {'help':'The name of the platform archive to be configured'}
+                    }
         HELP = "Platform-specific archive configuration"
         def __init__(self, config):
             stream = StringIO()
             stream.write("Current platform archive settings:\n")
             archives = {}
             for platform, description in config.get_all_platforms().iteritems():
                 if description.archive is not None:
                     archives[platform] = description.archive
             configfile.pretty_print(archives, stream)
             self.description = stream.getvalue()
             stream.close()
             self.config = config
         def _create_or_update_platform_archive(self, platform, format, hash_algorithm):
             try:
                 platform_description = self.config.get_platform(platform)
             except configfile.ConfigurationError:
                 platform_description = configfile.PlatformDescription({'name': platform})
                 self.config.package_description.platforms[platform] = platform_description
             if platform_description.archive is None:
                 platform_description.archive = configfile.ArchiveDescription()
             platform_description.archive.format = format
             platform_description.archive.hash_algorithm = hash_algorithm
         def run(self, platform=get_current_platform(), format=None, hash_algorithm=None):
             """
             Configure platform archive details.
             """
             self._create_or_update_platform_archive(platform, format, hash_algorithm)
         def delete(self, platform=get_current_platform(), **kwargs):
             """
             Delete the named config value.
             """
             print "Deleting %s archive entry." % platform
             platform_description = self.config.get_platform(platform)
             if platform_description is not None:
                 platform_description.archive = None
     class _package(InteractiveCommand):
         def __init__(self, config):
             stream = StringIO()
             stream.write("Current package settings:\n")
             configfile.pretty_print(config.package_description, stream)
             self.description = stream.getvalue()
             stream.close()
             self.config = config

autobuild/autobuild_tool_package.py
Revision ac90b03614ea	New Change

autobuild/common.py
Revision ac90b03614ea	New Change

autobuild/configfile.py
Revision ac90b03614ea	New Change

autobuild/tests/test_common.py
Revision ac90b03614ea	New Change

autobuild/tests/test_package.py
Revision ac90b03614ea	New Change

You have a pending review.

Other reviews

Your comment

Review Board 1.6.11

This change has been marked as submitted.

Adds support for packaging and extracting zip formatted archives

Diff revision 2 (Latest)