VWR-24254: Add support for using ld.gold on linux.


Submitter:	Aleric Inglewood	Reviewers
Branch:		Groups:	viewer
Bugs:	VWR-24254	People:
Change Number:	None	Repository:	viewer-development

Description:

To use ld.gold configure with:
  -DCMAKE_EXE_LINKER_FLAGS:STRING="-Wl,-use-gold".

See VWR-24254 for more details.

Testing Done:

ld.gold links the viewer on my machine in 8 seconds, as
opposed to 19 seconds with ld.bfd. Moreover, it uses a
LOT less memory during linking (about 750 MB instead of
2.5 GB! (for viewer 1)).

Since my machine locked up hard when I run out of memory
(something with using an encrypted RAID for my swap),
and compiling viewer 2 uses more than 3 GB, I couldn't
compile viewer 2 at all anymore without this patch (and
using ld.gold). And OMG this is fast!

Expand All

indra/cmake/LLCommon.cmake (Diff revision 1)

Is this removal related to ld.gold, too, or just general cleanup?

Aleric Inglewood Dec. 19, 2010, 6:38 p.m. (Dec. 19, 2010, 6:38 p.m.)

Oops. That was supposed to be a general cleanup, inspired by the fact that llcommon isn't including apu.h (the header that is being looked for for APRUTIL_INCLUDE_DIR). But because of your question I double checked, and although /usr/include/apr-1.0 contains
apr_*.h files and apu_*.h files, about half of the apr_*.h files belong to aprutil! And we DO use those (ie, apr_base64.h).
I'll change the patch to not remove that tomorrow.

Diff
- added Diff r2

Description:

Attached an incremental diff that reverts the removal of APRUTIL_INCLUDE_DIR

I haven't tried building on LINUX (I recommend whoever does the integration to run a TC build on a test repo for safety before merging in lindenlab/viewer-development) but everything seems sound to me. Ship it!

You have a pending review.

Other reviews

Your comment

Review Board 1.6.11

This change has been marked as submitted.