STORM-1577 Convert chat translation to third party paid translation services (take 2)
Review Request #466 - Created Sept. 12, 2011 and submitted
| Vadim ProductEngine | Reviewers | ||
| viewer | |||
| STORM-1577 | seth.productengine | ||
| None | viewer-development | ||
Replaced deprecated Google Translate v1 API with Google Translate v2 and Bing Translate APIs. Changes after https://codereview.secondlife.com/r/464/: * New translation preferences floater layout that supports API key verification. * Unit tests.
Expand AllPosted (Sept. 15, 2011, 8:04 a.m.)
-
indra/newview/llfloatertranslationsettings.cpp (Diff revision 1) -
Probably keystroke callback causes a bug with disabling the 'OK' button after successfull key verification upon moving the input cursor in line editor without actually editing the valid key.
-
indra/newview/llfloatertranslationsettings.cpp (Diff revision 1) -
Same problem as above.
-
indra/newview/tests/lltranslate_test.cpp (Diff revision 1) -
Tests 6 and 7 look exactly the same. Should do something different perhaps.
Posted (Sept. 15, 2011, 10:48 a.m.)
I'd like to see Doxygen style descriptions for all the classes, method, and parameters in the .h files, but other than that and the one spelling error this looks great.
-
indra/newview/lltranslate.h (Diff revision 1) -
What's a "Translarion" ?
Review request changed
Updated (Sept. 15, 2011, 2:57 p.m.)
-
- added Diff r2
* Fix: Don't enable the "Verify" button if use just moves cursor in the API key input field. * Fixed a copy&paste error in unit tests. * Fixed a typo: LLBingTranslarionHandler * Fixed a Windows compilation error. * Added Doxygen comments to lltranslate.h.
Looks good to me.
Other reviews