All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

STORM-918 Changes in Group Role Titles or Assignments Not Reflected in Title Dropdown

Review Request #461 - Created Aug. 31, 2011 and submitted

Vadim ProductEngine Reviewers
viewer
STORM-918 paul.productengine
None viewer-development 
Changes:
- Removed a useless (empty) notifyObservers() method.
- Fixed dummy widget creation.
- Removed a redundant getChild() call. We do the same in postBuild(), which is called earlier.
- Fixing a potential bug: early return from LLGroupMgr::notifyObservers(). Just noticed it while analyzing code.
- Update role titles in the General tab whenever they change in the Roles tab.

Only the last change is 100% relevant. Please see Bitbucket for more fine-grained change breakdown.

 

 










  

 


















 

  




 

 

  
Ship it!

  

  
Seth ProductEngine

  
Posted  (Sept. 1, 2011, 9:05 a.m.)

 

 

   
Looks good to me.