STORM-1028 Speak button label not displaying at default window size
Review Request #453 - Created Aug. 30, 2011 and submitted
| Vadim ProductEngine | Reviewers | ||
| viewer | |||
| STORM-1028 | |||
| None | viewer-development | ||
Fixed chat bar occupying all available space by default. Changes: - Make sure we initialize desired chat bar width before using it. - Don't attempt shrinking chat bar by negative amount of pixels (i.e. effectively extending it). This change may be irrelevant to the bug I'm fixing, but won't hurt anyway. - Restored my XML changes that had been lost in merges. - Minor changes (var names, message text) to improve readability. - Fixed a typo in comments.
Removed settings, verified that the default chat bar width is 250 px (maybe too small but that's a separate issue, see JIRA).
Expand AllReview request changed
Updated (Aug. 30, 2011, 4:51 a.m.)
-
Changes: - Make sure we initialize desired chat bar width before using it. - Don't attempt shrinking chat bar by negative amount of pixels (i.e. effectively extending it). This change may be irrelevant to the bug I'm fixing, but won't hurt anyway. - Restored my XML changes that had been lost in merges. - Minor changes (var names, message text) to improve readability. - Fixed a typo in comments.
Fixed chat bar occupying all available space by default. Changes: - Make sure we initialize desired chat bar width before using it. - Don't attempt shrinking chat bar by negative amount of pixels (i.e. effectively extending it). This change may be irrelevant to the bug I'm fixing, but won't hurt anyway. - Restored my XML changes that had been lost in merges. - Minor changes (var names, message text) to improve readability. - Fixed a typo in comments.
Other reviews