STORM-638 "Object Return" doesn't return distant objects


Submitter:	Vadim ProductEngine	Reviewers
Branch:		Groups:	viewer
Bugs:	STORM-638	People:	seth.productengine
Change Number:	None	Repository:	viewer-development

Description:

Reason: Showing the confirmation dialog resets object selection,
thus there is nothing to derez.

Fix: Save selection until user answers in the confirmation dialog.

I didn't investigate why the bug occurred only for distant object
(must be some internal LLSelectMgr magic).

Testing Done:

See acceptance criteria in the JIRA ticket.

Expand All

Testing Done

Changed from:

Changed to:

See acceptance criteria in the JIRA ticket.

Reviewers (People)
- added seth.productengine

indra/newview/llviewermenu.cpp (Diff revision 2)

This is dangerous!  Never hold on to raw pointers to llviewerobject, as they can be deleted from under you.  Use LLPointer instead.

I looked into fixing the underlying problem, but that involves revisiting the design of selections.  We always deselect objects beyond a certain distance in order to keep your avatar proximate to the objects you can affect (for various technical and social reasons).  This workaround is fine for now, if not ideal.

Vadim ProductEngine Aug. 26, 2011, 4:35 p.m. (Aug. 26, 2011, 4:35 p.m.)

Ah, crap. I was going to use an LLPointer but forgot then. Thank you very much for spotting, will fix!

do not ship until fixing the pointer problem

Diff
- added Diff r3

Description:

Fixed a silly pointer usage mistake.

thanks

You have a pending review.

Other reviews

Your comment

Review Board 1.6.11

This change has been marked as submitted.