All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

VWR-10579: Fix NDOF.cmake to do the right thing on standalone.

Review Request #45 - Created Dec. 19, 2010 and submitted

Aleric Inglewood Reviewers
viewer
VWR-10579
None viewer-development
On standalone, only define -DLIB_NDOF=1 when NDOF can be found.
I can't remember when I started using this, but it was long ago. I don't have libndofdev installed.
I just installed Michelle's debian package libndofdev-dev and then it found it:
-- Found NDOF: Library in '/usr/lib/libndofdev.so' and header in '/usr/include' 

Review request changed
Updated (Dec. 20, 2010, 6:04 a.m.)
  • Only define -DLIB_NDOF=1 when NDOF is actually found, on standalone. While FindNDOF.cmake was added to the repository, it wasn't used.

    On standalone, only define -DLIB_NDOF=1 when NDOF can be found.
This new patch addresses Boroondas -heh- preferences ;) it tries to find NDOF and when not found prints an error and the instructions to configure with -DNDOF:BOOL=OFF if you really don't want space navigator joystick support. This is indeed very simular to how FMOD works currently.

This new patch also adds indra/cmake/FindNDOF.cmake, which was erroneously missing from the first patch, oops!