STORM-1567 Mute button for llDialog popup


Submitter:	Jonathan Yap	Reviewers
Branch:	v2.7.3	Groups:	viewer
Bugs:	STORM-1567	People:
Change Number:	None	Repository:	viewer-development

Description:

Add a block button to popups from llDialog calls.  Clicking on the Block button adds the object to the block list.  The type of block is Object.  Changing the object's name does not defeat this block as the block entry is stored as a UUID.

Note: The object's name in the block list does not change if the object is renamed, though the block does work.  This may need to be addressed in a separate SVC jira once this change is incorporated into viewer-development.

Testing Done:

Tested per Test Plan jira entry.

Expand All

These changes don't apply to the v-d tip.
Please create a fresh fork, submit the patch to it and publish the repo link in the JIRA ticket, which should be in the Reviewing state.

Diff
- added Diff r2

Description:

Original diff applied to current version of viewer-development per Vadim's request.  New diff based on this changed applied here.

indra/newview/lltoastnotifypanel.cpp (Diff revision 2)

The surrounding code looks quite messy (not your fault, I know), so please make more comments to the code you add.

Jonathan Yap Aug. 26, 2011, 9:03 a.m. (Aug. 26, 2011, 9:03 a.m.)

Looking over this mathematical mess I found that ignore_btn_hoffset was a leftover from when I was developing this change and was no longer needed.

I have added one comment.

indra/newview/lltoastnotifypanel.cpp (Diff revision 2)

I didn't go through the calculations, but the Mute button is visually bigger than the Ignore button. Is it intentional?

Jonathan Yap Aug. 26, 2011, 9:05 a.m. (Aug. 26, 2011, 9:05 a.m.)

Yes the block button is larger than the ignore button because:
1) It is the same size as is found in other instances in the UI where it appears.
2) I did not know if making it smaller would affect the width needed for language translations.

indra/newview/llviewermessage.cpp (Diff revision 2)

It's a hack to update the Block List panel from here.
The panel should be an observer of the mute list, or something like that, i.e. update itself automatically.

Jonathan Yap Aug. 26, 2011, 9:10 a.m. (Aug. 26, 2011, 9:10 a.m.)

This exact same call is used in 6 other places in the code.  It forces the sidebar open and highlights the newly Blocked item as feedback to the user that their Block click has had some effect, so I think having this call is correct.

Vadim ProductEngine Aug. 26, 2011, 9:19 a.m. (Aug. 26, 2011, 9:19 a.m.)
```
Ah, right. You see -- more comments won't hurt! :-)
```

indra/newview/skins/default/xui/en/notifications.xml (Diff revision 2)

I suppose these changes must be also made to the "ScriptDialog" notification template.

Jonathan Yap Aug. 26, 2011, 9:10 a.m. (Aug. 26, 2011, 9:10 a.m.)
```
Good catch!
```

Diff
- added Diff r3

Description:

New diff to reflect changes made from RB comments.

You have a pending review.

Other reviews

Your comment

Review Board 1.6.11

This change has been marked as submitted.