JavaScript is turned off

Review Board requires JavaScript in order to function. Please turn it on in your browser preferences.

Firefox users: if you prefer to turn on JavaScript only for specific sites, we recommend the NoScript extension.


Submitter:	Nicky Perian	Reviewers
Branch:		Groups:	viewer
Bugs:	OPEN-112	People:
Change Number:	None	Repository:	viewer-development

Description:

Note: In code comments are for code review only and will be removed.
Debug builds have openjpegd.dll and it is a dependency for some of the unit tests. However, the viewer (secondlife-bin.exe) has openjpeg.dll dependency. It is the same debug library but, without the 'd' in its name. So, there are two or more dependencies of the same library with different names. This can be tested by building a debug configuration and invoking the viewer and then, the error appears about the missing openjpeg.dll. Then, change the name of openjpegd.dll to openjpeg.dll and invoke the viewer again. This time it should run correctly and present the log in page. Modifications are need to add a copy instruction so that both named versions of the debug library are present in the openjpeg archive. Additional modifications to the viewer are needed to place openjpeg.dll properly; while leaving openjpegd.dll in place for unit tests.

Testing Done:

Built Debug configuration with revised local library. Copy of revised library is here: http://bitbucket.org/NickyP/viewer-development-open-112/downloads/openjpeg-1.4-windows-20110819.tar.bz2 
MD5 hash is 271a8e9253efaef9884181cd58984dd9.
Logged in to aditi mesh city and walked around. No problems noted.

Expand All

> Note: In code comments are for code review only and will be removed.
As the comments indicate that this is a temporary hack, they should go in with the code, if the code is to go in. That is crucial information to anyone editing that code.

Though, is there a reason why we can't just fix this the right way right away instead of working around the problem first?

indra/cmake/Copy3rdPartyLibs.cmake (Diff revision 1)

Don't add trailing whitespace.

indra/cmake/Copy3rdPartyLibs.cmake (Diff revision 1)

Removing the '[' here leaves the ']' unbalanced, so I doubt that's right.

Diff
- added Diff r2

Description:

From Boroondas review.
Removed trailing white space. Corrected an editing error for a removed bracket caused by trying to align text.

In code comments can be left in if appropriate.

Summary changed from Windows debug build fails at run time because of an absent openjpeg.dll. to OPEN-112 Windows debug build fails at run time because of an absent openjpeg.dll.
Bugs Closed
- removed https://jira.secondlife.com/browse/OPEN-112
- added OPEN-112

You have a pending review.

Other reviews

Your comment

Review Board 1.6.11

OPEN-112 Windows debug build fails at run time because of an absent openjpeg.dll.