STORM-632 URL-like resident display name is shown as clickable HTTP URL in various places (additional fix)


Submitter:	Vadim ProductEngine	Reviewers
Branch:		Groups:	viewer
Bugs:	STORM-632	People:	richard.linden
Change Number:	None	Repository:	viewer-development

Description:

Disallow showing URL-like avatar display names as Web links in the ShareItemsConfirmation notification.

Updating the <nolink> tag parsing regexp to enable multiple <nolink>...</nolink> clauses in a single textbox.

Testing Done:

Expand All

Reviewers (People)
- added richard.linden

Description:

Adding Richard to reviewers.

indra/llui/llurlentry.cpp (Diff revision 1)

This regexp will not allow nested tags.  I'm not sure if we can handle or use nested tags, but it would seem to be better to use:

boost::regex("<nolink>.?</nolink>")

this will consume as few characters as possible between the opening and closing tags, thus allowing multiple "nolink"s

Vadim ProductEngine Aug. 11, 2011, 12:46 p.m. (Aug. 11, 2011, 12:46 p.m.)

If I'm not mistaken, this regexp would not allow more than one character between the tags.

Richard Nelson Aug. 11, 2011, 12:50 p.m. (Aug. 11, 2011, 12:50 p.m.)
```
You are right, I meant .*?
```
Vadim ProductEngine Aug. 12, 2011, 5:37 a.m. (Aug. 12, 2011, 5:37 a.m.)
```
Thanks Richard, this is what I needed!
```

Diff
- added Diff r2

Description:

Use non-greedy regexp match to enable multiple <nolink>...</nolink> clauses in a single textbox.

looks good!

You have a pending review.

Other reviews

Your comment

Review Board 1.6.11

This change has been marked as submitted.