STORM-1427 Crash in world map when region name search is empty (Assert fails in LLWorldMapMessage::processMapBlockReply)
Review Request #432 - Created Aug. 5, 2011 and submitted
Vadim ProductEngine | Reviewers | ||
viewer | |||
STORM-1427 | |||
None | viewer-development |
Fixed a debug assertion triggered in the world map floater. Apparently, passing empty region name to the MapNameRequest makes server return empty name in MapBlockReply, which triggered the assertion.
Posted (Aug. 5, 2011, 2:07 p.m.)
Thanks for looking into this. I've stopped counting how often I've crashed due to this. > Apparently, passing empty region name to the MapNameRequest makes server return > empty name in MapBlockReply, which triggered the assertion. Shouldn't we warn rather than assert when we receive invalid (or just useless) data from remote (whether by our own or the servers' fault)? I don't think any service should be given the power to 'shoot down' the viewer.
-
indra/newview/llfloaterworldmap.cpp (Diff revision 1) -
Instead of returning early ...
-
indra/newview/llfloaterworldmap.cpp (Diff revision 1) -
... you could wrap the remainder of the method into a conditional block.
I don't agree with your early return rationale, but let's just go with this.
> The assert will not be in issue for release builds. > Triggering it in debug builds help catching bugs, as in this case. > Besides, the assert was added in attempt to locate another bug (EXT-4568), so I'd just leave it. Sounds reasonable.
Review request changed
Updated (Aug. 8, 2011, 10:51 a.m.)
- changed from STORM-1427 to
-
- added STORM-1427
Fixed JIRA ticket reference.
Other reviews