STORM-1534: Derive Credits lists of contributors and translators from doc/ files
Review Request #427 - Created Aug. 2, 2011 and submitted
| Oz Linden | Reviewers | ||
| viewer | |||
| storm-1534 | |||
| None | viewer-development | ||
In the Help>About Second Life dialog, there are lists of users who have contributed to the viewer and provided translations. Prior to this change, those lists had to be updated manually (and had not been updated in quite some time). Since we have a separate file (doc/contributions.txt) to track contributions, and it is in an easily parseable format, this change modifies the viewer build to construct a file (app_settings/contributors.txt) containing those names, and another for the translators (app_settings/translators.txt) from a new doc/translations.txt file (the contents of which are not complete in this patch, but are sufficient for review and testing purposes). I also removed the list of Lindens from the dialog, as it too had not been updated in a long time and replaced it with a more generic statement.
So far built and tested only locally on my Mac... will set up a TeamCity build for other platforms shortly and add a pointer here. See screenshot on the jira issue.
Expand AllPosted (Aug. 2, 2011, 3:57 p.m.)
Works on windows within the IDE as long as 'package' is enabled (obviously) or the credits lists are blank (expected).
Review request changed
Updated (Aug. 3, 2011, 5:56 a.m.)
-
- added Diff r2
Restored the list of Lindens, which for the time being will have to be maintained by hand. Screen shot updated on Jira
Review request changed
Updated (Aug. 3, 2011, 5:59 a.m.)
-
- added Diff r3
fix diff upload
Review request changed
Updated (Aug. 3, 2011, 2:58 p.m.)
-
- added Diff r4
Modified code to load dynamic Lindens list provided at build time if available, and use the static value from the xui if not. Further build changes needed to fetch that Linden list at build time.
Review request changed
Updated (Aug. 6, 2011, 6:14 a.m.)
-
- added Diff r5
the code for this is complete now... there are additions still needed to the list of translators
Looks plausible.
-
indra/newview/viewer_manifest.py (Diff revision 5) -
Shouldn't the regexp start with a caret (which denotes beginning of the line) ?
-
indra/newview/viewer_manifest.py (Diff revision 5) -
same here
Other reviews