STORM-1220 Region / Estate > Covenant - Type of region is in EN: "Estate / Full Region"
Review Request #414 - Created July 25, 2011 and submitted
Vadim ProductEngine | Reviewers | ||
viewer | |||
STORM-1220 | |||
None | viewer-development |
Localized sim product name (e.g. "Estate / Full Region") everywhere.
Posted (July 25, 2011, 10:44 a.m.)
-
indra/newview/llfloaterland.cpp (Diff revision 2) -
+1 for moving this re-occurring code into a method. :-)
-
indra/newview/llfloaterland.cpp (Diff revision 2) -
Is it save to remove this NULL-check? AFAIK getChild<...>() can fail.
-
indra/newview/llfloaterregioninfo.cpp (Diff revision 2) -
Is it save to remove this NULL-check? AFAIK getChild<...>() can fail.
-
indra/newview/llviewerregion.h (Diff revision 2) -
Can (and maybe should) be made private now. I don't think any other class has a valid reason to use the unlocalized name. Or just remove it, and use directly use mProductName in getLocalizedSimProductName().
Review request changed
Updated (July 25, 2011, 1:51 p.m.)
-
- added Diff r3
Removed LLViewerRegion::getSimProductName() so that it doesn't mistakenly get used in UI code, thus causing localization bugs.
Other reviews