All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

Change pre-login viewer display URL to prepare for new community information display

Review Request #399 - Created July 16, 2011 and submitted

Oz Linden Reviewers
viewer
storm-1510
None viewer-development 
This changes the URL from which the upper part of the viewer window is loaded prior to login.

At the moment, the new URL is internally redirected to the same content as before, but shortly it will have new community and activity information on what's going on in Second Life.
Confirmed using the log file that the new URL is being requested.
Changed the settings file locally to point to an internal prototype of the new screen and confirmed that it is displayed correctly.
Thickbrick Sleaford
Posted (July 16, 2011, 6:48 a.m.)

   

  

   

   
    
    
   


  






   







    

     
     

      

       
        

         
          indra/newview/app_settings/settings.xml
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    

     
Setting the default value to something other than an empty string would override the selected grid's login page in LLGridManager::getGridInfo and LLGridManager::getLoginPage, which is probably not the desired result. In fact, I wonder why this setting is persistent at all. This should probably be renamed to CmdLineLoginPage, to be consistent with CmdLineLoginURI etc.


     

  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    That may be true (have not checked), but this same URL is the login page for all our grids, it doesn't matter.

I confirmed that overriding on the command line does work.

    
    
    
   
    2. 


   
  2. 
    
    
     
    
      
     
    
     
    Would this change affect anything when connecting to a non-LL grid?
    
    
    
   
    3. 

   


  





    

    

   


  
 




  

 



















 

  




 

 

  
Ship it!

  

  
Richard Nelson

  
Posted  (July 18, 2011, 10:02 a.m.)

 

 

   
Looks good, let's try it without the change to settings.xml, though.